Introspection: add typing.final on final classes #5552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
An other approach might be to add a Edit: moving to draft, this decorators idea makes more sense |
Contributor
Author
|
I have rebased the MR to use the new decorators mechanism |
davidhewitt
reviewed
Nov 18, 2025
| if let TypeHintExpr::Identifier(i) = expr { | ||
| Ok(i) | ||
| } else { | ||
| bail!("A decorator must be the identifier of a Python function") |
Member
There was a problem hiding this comment.
A decorator can also be a call to such function, I guess we can support in future? (Should the error message be clearer, if so?)
32 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.